Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Another D3D8(LTCG) signatures update #193

Merged
merged 6 commits into from
Mar 6, 2023

Conversation

RadWolfie
Copy link
Member

See commits' body for what been changed.

Fixed:

  • Regression in Grand Theft Auto: San Andreas for missing D3DDevice_DrawIndexedVertices symbol due to small portion of instructions was shifted by one offset.
  • False positive for D3DDevice_DrawVerticesUP symbol matching with D3DDevice_DrawIndexedVerticesUP address.
  • Some duplicate signature warnings during scan process and additional detection too.

Renamed some LTCG symbols to align with new change relative to register parameters usage.

Currently unit test is passing after rename correction for both LTCG and non-LTCG titles.

Removed:
- CDevice_SetStateUP (4134)
- CDevice_LazySetStateUP (5028, 5558)

Added:
- CDevice_SetStateUP_4 (3911)
- CDevice_SetStateUP_0__LTCG_esi1 (4039, 4040 aka 2nd revision)

Updated:
- CDevice_SetStateUP (3911, 4034)
Renamed:
- D3DDevice_BeginPush2 to D3DDevice_BeginPush_8
- D3DDevice_BeginPush to D3DDevice_BeginPush_4

Updated:
- D3DDevice_BeginPush_8 (4039)
- D3DDevice_BeginPush_4 (4531, 4627, 5028)
- D3DDevice_BeginPush_4 (1024)
Renamed:
- D3DDevice_DrawVerticesUP_12 to D3DDevice_DrawVerticesUP_12__LTCG_ebx3

Removed:
- D3DDevice_DrawIndexedVerticesUP (1036, 1060)
- D3DDevice_DrawVerticesUP (1060, 1036)

Updated:
- D3DDevice_DrawIndexedVerticesUP (3911, 5028, 5344)
- D3DDevice_DrawIndexedVerticesUP (1024, 1036, 1048)
- D3DDevice_DrawVerticesUP (3911, 4039, 5344)
- D3DDevice_DrawVerticesUP (1024, 1048)
- D3DDevice_DrawVerticesUP_12__LTCG_ebx3 (2024)
Renamed:
- D3DDevice_DrawVertices_8 to D3DDevice_DrawVertices_8__LTCG_eax3

Removed:
- D3DDevice_DrawVertices_8__LTCG_eax3 (2048)

Updated:
- D3DDevice_DrawVertices (3911)
- D3DDevice_DrawVertices (1024)
- D3DDevice_DrawVertices_8__LTCG_eax3 (4039)
- D3DDevice_DrawVertices_4__LTCG_ecx2_eax3 (2024)

Added:
- D3DDevice_DrawIndexedVertices (1037)
Removed:
- 1024

Updated:
- 3911, 1024
@github-actions github-actions bot added D3D8 OOVPA relative topic D3D8LTCG OOVPA relative topic needs-verification Require verification before approval OOVPA Any OOVPA change relative labels Mar 6, 2023
@RadWolfie RadWolfie changed the title Another D3D signatures update Another D3D8(LTCG) signatures update Mar 6, 2023
Copy link
Member

@PatrickvL PatrickvL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@RadWolfie RadWolfie removed the needs-verification Require verification before approval label Mar 6, 2023
@RadWolfie RadWolfie merged commit 7741113 into Cxbx-Reloaded:master Mar 6, 2023
@RadWolfie RadWolfie deleted the d3d-update branch March 6, 2023 11:41
@RadWolfie RadWolfie linked an issue Mar 6, 2023 that may be closed by this pull request
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
D3D8LTCG OOVPA relative topic D3D8 OOVPA relative topic OOVPA Any OOVPA change relative
Projects
None yet
Development

Successfully merging this pull request may close these issues.

D3DDevice_BeginPush(2) inaccurate name setup
2 participants