HOTFIX: fix endless loop for dependency flag check is completed or not #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ergo720
reviewed
Oct 28, 2023
RadWolfie
force-pushed
the
hotfix-endless-loop
branch
from
086e6ff to
8b1ba21
Compare
ergo720
approved these changes
Oct 28, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After reviewing codebase, I believe I found the source of endless loop for when dependency flags are returned but never checked if any of them are matched. Instead of fix cli and unittest tools, I recommended to fix it internally to work as intentional design. This fixed certain Chihiro titles containing D3D8I library except absent of D3D8I signatures support.
fixed #197