Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Serialization info txt files changing without implementation change #353

Open
ngburke opened this issue Nov 27, 2024 · 0 comments
Open

Serialization info txt files changing without implementation change #353

ngburke opened this issue Nov 27, 2024 · 0 comments

Comments

@ngburke
Copy link

ngburke commented Nov 27, 2024

When using the very helpful serialization info to catch changes in structs per:

<!-- output memorypack serialization info to directory -->
<ItemGroup>
    <CompilerVisibleProperty Include="MemoryPackGenerator_SerializationInfoOutputDirectory" />
</ItemGroup>
<PropertyGroup>
    <MemoryPackGenerator_SerializationInfoOutputDirectory>$(MSBuildProjectDirectory)\MemoryPackLogs</MemoryPackGenerator_SerializationInfoOutputDirectory>
</PropertyGroup>

I'm getting strange changes in the text file output like so, with no underlying changes to the structs - GenerateType is being changed to GanerateType?

Screenshot 2024-11-27 at 9 23 27 AM

The implementation of this struct is as follows. I am seeing this problem with a few other structs, no issues seen yet with classes. It is making the CI flag changes when there are none.

[MemoryPackable]
public readonly partial struct NodeState(Serialize.NodeType type, Vector3 position, Vector3 size, Identifier ident, int variant, int level, bool levelUpCandidate)
{
    public readonly Serialize.NodeType Type = type;
    public readonly Vector3 Position = position;
    public readonly Vector3 Size = size;
    public readonly Identifier Ident = ident;
    public readonly int Variant = variant;
    public readonly int Level = level;
    public readonly bool LevelUpCandidate = levelUpCandidate;
}
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant