Reorder intialization to erase warning(NFC) #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Ubuntu 22.04, GCC warns that the initialization order doesn't match the member declaration order.
Let's erase it if it's unintentional. :)
[1/2] Building CXX object CMakeFiles/cegss.dir/main.cpp.o In file included from /home/khei4/git/liboai/liboai/include/components/../core/network.h:18, from /home/khei4/git/liboai/liboai/include/components/../core/authorization.h:19, from /home/khei4/git/liboai/liboai/include/components/audio.h:14, from /home/khei4/git/liboai/liboai/include/liboai.h:31, from /home/khei4/git/cegss/main.cpp:7: /home/khei4/git/liboai/liboai/include/components/../core/netimpl.h: In copy constructor ‘liboai::netimpl::components::WriteCallback::WriteCallback(const liboai::netimpl::components::WriteCallback&)’: /home/khei4/git/liboai/liboai/include/components/../core/netimpl.h:600:98: warning: ‘liboai::netimpl::components::WriteCallback::callback’ will be initialized after [-Wreorder] 600 | std::function<bool(std::string data, intptr_t userdata)> callback; | ^~~~~~~~ /home/khei4/git/liboai/liboai/include/components/../core/netimpl.h:599:50: warning: ‘intptr_t liboai::netimpl::components::WriteCallback::userdata’ [-Wreorder] 599 | intptr_t userdata{}; |