Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Makes the key headers standout #144

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Conversation

skrawcz
Copy link
Contributor

@skrawcz skrawcz commented Apr 7, 2024

It's hard to quickly scroll and see the headlines. Went with a conservative black, rather than green
or something.

Changes

  • data view headers should now stand out

Before:
Screen Shot 2024-04-07 at 2 08 33 PM

After:
Screen Shot 2024-04-07 at 2 08 00 PM

How I tested this

  • locally

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

It's hard to quickly scroll and see the headlines.
Went with a conservative black, rather than green
or something.
@skrawcz skrawcz requested a review from elijahbenizzy April 7, 2024 21:11
Copy link
Contributor

@elijahbenizzy elijahbenizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@elijahbenizzy elijahbenizzy merged commit 0d742b0 into main Apr 8, 2024
8 checks passed
@elijahbenizzy elijahbenizzy deleted the make_data_keys_standout branch April 8, 2024 16:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants