Adds JSON view for numeric list -- this is easier to deal with #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elijahbenizzy
force-pushed
the
add-json-view-for-numeric-list
branch
from
efb9617 to
175ce21
Compare
|
will this work for top level number arrays too? I remember having code in two spots for this reason (IIRC). |
From what I can tell that's actually not necessary. |
|
Cool -- but I see you've injected a |
So that the array view looks good.
|
|
|
note: rendering is a little sluggish with this. |
skrawcz
approved these changes
Apr 14, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can just reuse the JSON view for this, its pretty clean.
