Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adds more badges to readme #456

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Adds more badges to readme #456

merged 1 commit into from
Dec 4, 2024

Conversation

skrawcz
Copy link
Contributor

@skrawcz skrawcz commented Dec 4, 2024

So that people can follow more etc.

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

Important

Add LinkedIn and Twitter badges to README.md for increased visibility.

  • README.md:
    • Added LinkedIn badge for DAGWorks.
    • Added Twitter badges for burr_framework and DAGWorks.

This description was created by Ellipsis for e32b590. It will automatically update as commits are pushed.

So that people can follow more etc.
@skrawcz skrawcz merged commit 0eec005 into main Dec 4, 2024
11 checks passed
@skrawcz skrawcz deleted the skrawcz-patch-2 branch December 4, 2024 19:13
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to e32b590 in 8 seconds

More details
  • Looked at 20 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. README.md:11
  • Draft comment:
    The LinkedIn and Twitter badges are redundant and inconsistent in style. Consider removing duplicates and ensuring consistent styling across all badges.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The badges for Twitter and LinkedIn are redundant and inconsistent in style.

Workflow ID: wflow_D8e0q2zNxTImKjui


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

github-actions bot commented Dec 4, 2024

A preview of is uploaded and can be seen here:

https://burr.dagworks.io/pull/456

Changes may take a few minutes to propagate. Since this is a preview of production, content with draft: true will not be rendered. The source is here: https://github.com/DAGWorks-Inc/burr/tree/gh-pages/pull/456/

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant