Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

README: add/explain SetMaxOpenConns(1) #70

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stapelberg
Copy link

Concurrent transactions are unsupported by txdb.

related to issue #69

Concurrent transactions are unsupported by txdb.

related to issue DATA-DOG#69
@flimzy
Copy link
Collaborator

flimzy commented Oct 16, 2024

Thanks for the PR. My concern with this is that I think it's overly prescriptive. It's not always adviseable to set max connections to 1. It depends a lot on your application. I think some additional explanation is warranted. I'll see if I can find some time to do that, if you don't get to it first.

@stapelberg
Copy link
Author

Thanks for the PR. My concern with this is that I think it's overly prescriptive. It's not always adviseable to set max connections to 1. It depends a lot on your application. I think some additional explanation is warranted. I'll see if I can find some time to do that, if you don't get to it first.

I’m not sure why setting max connections to 1 isn’t a good default. Over in issue #69 you mentioned that this could lead to deadlocks in certain applications, but I’m not sure under which conditions exactly. (And probably a deadlock is easier to debug than the current flakyness.)

Feel free to modify the PR directly, or merge and adjust as you see fit.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants