gcroot: addressing review comments

- replaced fmt.sprintf with filepath.join - fixed directory permission bits
DBCDK · May 8, 2019 · 76fa9fc · 76fa9fc
1 parent 97928f9
commit 76fa9fc
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/nix/nix.go b/nix/nix.go
@@ -140,12 +140,9 @@ func (ctx *NixContext) BuildMachines(deploymentPath string, hosts []Host, nixArg
 	}
 	hostsArg += "]"
 
-	resultLinkPath :=
-	  fmt.Sprintf("%s/.gcroots/%s",
-                      path.Dir(deploymentPath),
-                      path.Base(deploymentPath))
+	resultLinkPath := filepath.Join(path.Dir(deploymentPath), ".gcroots", path.Base(deploymentPath))
 	if ctx.KeepGCRoot {
-	  if err = os.MkdirAll(path.Dir(resultLinkPath), 755) ; err != nil {
+	  if err = os.MkdirAll(path.Dir(resultLinkPath), 0755) ; err != nil {
 		  ctx.KeepGCRoot = false;
 		  fmt.Fprintf(os.Stderr, "Unable to create GC root, skipping: %s", err)
 	  }