nix: add config file to NIX_SSHOPTS #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd really like to see this merged as well 😅 |
andir
reviewed
Mar 29, 2021
| sshOpts = append(sshOpts, fmt.Sprintf("%s", "-o StrictHostkeyChecking=No -o UserKnownHostsFile=/dev/null")) | ||
| } | ||
| if ctx.ConfigFile != "" { | ||
| sshOpts = append(sshOpts, fmt.Sprintf("-F %s", ctx.ConfigFile)) |
There was a problem hiding this comment.
Can thing config file be an output of a nix builder or does it have to exist before the deployment is started?
There was a problem hiding this comment.
I don't see why not. As long as it returns a path and ssh can access that path when passing -F /path, should be fine.
|
@srhb Do you have a minute to look at this? :-) |
|
I ran into the same bug today and came up with a similar solution (using a string builder). Regardless, i prefer your solution :) |
gilligan
reviewed
Apr 16, 2021
srhb
approved these changes
Apr 29, 2021
|
Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #140.
I don't actually use Morph (yet?), but I semi-validated that this should work by printing the value of
sshOpts, which showed[-o StrictHostkeyChecking=No -o UserKnownHostsFile=/dev/null -F /tmp]when runningSSH_SKIP_HOST_KEY_CHECK=true SSH_CONFIG_FILE=/tmp result/bin/morph push ./examples/healthchecks.nix.