Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Sort up usage of targetHost #86

Merged
merged 1 commit into from
Nov 11, 2019
Merged

Sort up usage of targetHost #86

merged 1 commit into from
Nov 11, 2019

Conversation

fooker
Copy link
Contributor

@fooker fooker commented Nov 7, 2019

This fixes #77. It uses the target name for most error and status
messages (and appends the targetHost where relevant), for filtering
targets and for building the derivations.

This fixes DBCDK#77. It uses the target name for most error and status
messages (and appends the `targetHost` where relevant), for filtering
targets and for building the derivations.
@johanot
Copy link
Contributor

johanot commented Nov 7, 2019

Thanks a lot for this! Will give it a test-spin and review tomorrow.

Copy link
Contributor

@johanot johanot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks again.

@johanot johanot merged commit 6f8540d into DBCDK:master Nov 11, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When deployment.targetHost is set it tries to build the wrong target
2 participants