Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

allow AMQP channel multiplexing #43

Merged
merged 2 commits into from
Aug 2, 2019
Merged

allow AMQP channel multiplexing #43

merged 2 commits into from
Aug 2, 2019

Conversation

satta
Copy link
Member

@satta satta commented Jul 12, 2019

This PR introduces a new feature:

  • No longer create a new connection and channel for each desired exchange submitter, but reuse existing channels if they exist. This should help decrease the number of connections on the RabbitMQ server side.

Also fixes a bug that can cause infinite loops in goroutines after AMQP reconnects.

@satta
allow AMQP channel multiplexing
3fee867 
Also fixes a bug that would cause infinite loops in goroutines
after AMQP reconnects.
@satta satta added enhancement New feature or request bug Something isn't working labels Jul 18, 2019
@satta satta requested a review from rhaist July 18, 2019 13:46
@satta satta mentioned this pull request Jul 23, 2019
Closed
@satta satta requested review from geertjanvdk and removed request for rhaist July 30, 2019 09:50
@satta satta assigned geertjanvdk and unassigned rhaist Jul 30, 2019
geertjanvdk
geertjanvdk reviewed Jul 31, 2019
View reviewed changes
util/submitter_amqp.go Outdated Show resolved Hide resolved
geertjanvdk
geertjanvdk reviewed Jul 31, 2019
View reviewed changes
util/submitter_amqp.go Outdated Show resolved Hide resolved
@geertjanvdk geertjanvdk merged commit d16cdf8 into DCSO:master Aug 2, 2019
@satta satta deleted the submitter_unify branch August 19, 2019 09:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@geertjanvdk geertjanvdk geertjanvdk left review comments

Assignees

@geertjanvdk geertjanvdk

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@satta @geertjanvdk @rhaist