fix parsing of JSON null values #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0mbi
reviewed
Jan 25, 2022
Done! |
0mbi
approved these changes
Jan 25, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the way FEVER currently handles incoming JSON fields that are
null(not the string"null"but a JSON null value): These cause a parse error, as they are not handled correctly by the low-leveljsonparser.Parse*()function used in the main JSON parser code. We need to explicitly check for those and skip them.Note (for peace of mind) that this issue is not relevant for incoming Suricata EVE-JSON (as this will never set
nullfields) but only when handling EVE-JSON from other sources.