Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update Issue/321 #30

Merged
merged 4 commits into from
Mar 16, 2021
Merged

Conversation

Gamebuster19901
Copy link

@Gamebuster19901 Gamebuster19901 commented Mar 16, 2021

  • Removes some unused imports,
  • Import/Export Animation Exceptions subclass IOException instead of Error
  • Fixes a build error

The build error was the following:

gamebuster@gamebuster-System-Product-Name:~/Desktop/Modding/LitiEngine$ ./gradlew build

> Task :compileJava FAILED
/home/gamebuster/Desktop/Modding/LitiEngine/src/de/gurkenlabs/litiengine/graphics/animation/AsepriteHandler.java:270: error: cannot infer type arguments for HashMap<K,V>
        Map<String, Integer> frame = new HashMap<>() {{
                                                ^
  reason: cannot use '<>' with anonymous inner classes
  where K,V are type-variables:
    K extends Object declared in class HashMap
    V extends Object declared in class HashMap
/home/gamebuster/Desktop/Modding/LitiEngine/src/de/gurkenlabs/litiengine/graphics/animation/AsepriteHandler.java:276: error: cannot infer type arguments for HashMap<K,V>
        Map<String, Integer> spriteSourceSize = new HashMap<>() {{
                                                           ^
  reason: cannot use '<>' with anonymous inner classes
  where K,V are type-variables:
    K extends Object declared in class HashMap
    V extends Object declared in class HashMap
/home/gamebuster/Desktop/Modding/LitiEngine/src/de/gurkenlabs/litiengine/graphics/animation/AsepriteHandler.java:282: error: cannot infer type arguments for HashMap<K,V>
        Map<String, Integer> sourceSize = new HashMap<>() {{
                                                     ^
  reason: cannot use '<>' with anonymous inner classes
  where K,V are type-variables:
    K extends Object declared in class HashMap
    V extends Object declared in class HashMap
/home/gamebuster/Desktop/Modding/LitiEngine/src/de/gurkenlabs/litiengine/graphics/animation/AsepriteHandler.java:301: error: cannot infer type arguments for HashMap<K,V>
    Map<String, Integer> size = new HashMap<>() {{
                                           ^
  reason: cannot use '<>' with anonymous inner classes
  where K,V are type-variables:
    K extends Object declared in class HashMap
    V extends Object declared in class HashMap
4 errors

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':compileJava'.
> Compilation failed; see the compiler error output for details.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 552ms
3 actionable tasks: 2 executed, 1 up-to-date

Fixes a build error. The error was:
```
/home/gamebuster/Desktop/Modding/LitiEngine/src/de/gurkenlabs/litiengine/graphics/animation/AsepriteHandler.java:270:
error: cannot infer type arguments for HashMap<K,V>
        Map<String, Integer> frame = new HashMap<>() {{
                                                ^
  reason: cannot use '<>' with anonymous inner classes
  where K,V are type-variables:
    K extends Object declared in class HashMap
    V extends Object declared in class HashMap
```
Copy link
Collaborator

@nwessman nwessman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix!

@nwessman nwessman merged commit 3144975 into DD2480-Group-11:issue/321 Mar 16, 2021
@Gamebuster19901 Gamebuster19901 deleted the issue/321 branch March 16, 2021 18:58
@Gamebuster19901 Gamebuster19901 restored the issue/321 branch March 16, 2021 19:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants