-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix deferred course start date on offer deferred #9880
Conversation
Previously, it didn't show the actual date of the course start when it's deferred
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the application has been deferred, there exists a course in the next cycle with a start date, right? Would it be better to get the start date for that course?
application_choice.current_course.start_date
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We render this same information in the application_status_tag_component.
It is correctly rendered there.
I'm happy with the method you've written, or Iain's suggestion (I don't feel strongly about it). But it would be good to use the same method in both places.
65232ef
to
b68d26e
Compare
b68d26e
to
2fd1ed1
Compare
app/components/candidate_interface/application_status_tag_component.html.erb
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Context
Previously, it didn't show the actual date of the course start when it's deferred.
It was showing the date of the current cycle, not the next. So 2024 not 2025 for example
Changes proposed in this pull request
Added deferred_start_date
Guidance to review
Is the logic of the method correct?
Go on the review app and # as a candidate with a deferred offer and check the start date of your course is correct, in the next cycle, should be 2025 for a deferred offer in 2024 cycle
Screencast.2024-09-27.11.47.04.mp4
Things to check