Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[8.0] Elasticsearch generateDocs: remove multiplication in timestamp when committing to monitoring #6076

Merged
merged 6 commits into from
Jun 14, 2022

Conversation

rupozzi
Copy link
Member

@rupozzi rupozzi commented May 13, 2022

This is a way to resolve #5320 without going to the ES backend and manipulate old indices.
Very simply, let us make sure that when a record is added to ES, it already has a timestamp in milliseconds, and skip the whole multiplication process when committing it.

BEGINRELEASENOTES

*Monitoring
FIX: Removing multiplication in timestamp when committing to monitoring

ENDRELEASENOTES

@rupozzi rupozzi changed the title Removing multiplication in timestamp when committing to monitoring [integration] Elasticsearch generateDocs: remove multiplication in timestamp when committing to monitoring May 13, 2022
@rupozzi
Copy link
Member Author

rupozzi commented May 13, 2022

Another topic worth discussing brought up by @chaen in #5320 would be also whether we should even add a timestamp at all when committing the records, when we could instead add it directly when adding the record.

@rupozzi rupozzi force-pushed the timestamp-issue branch 4 times, most recently from 6536c4f to 3bf2af7 Compare June 8, 2022 14:59
@rupozzi rupozzi force-pushed the timestamp-issue branch from 0b87749 to 68a18ac Compare June 9, 2022 07:38
@rupozzi rupozzi marked this pull request as ready for review June 9, 2022 07:39
@rupozzi rupozzi requested review from fstagni, chaen and atsareg as code owners June 9, 2022 07:39
@rupozzi rupozzi force-pushed the timestamp-issue branch from 8bf6e91 to 0649381 Compare June 9, 2022 13:31
@fstagni fstagni changed the title [integration] Elasticsearch generateDocs: remove multiplication in timestamp when committing to monitoring [8.0] Elasticsearch generateDocs: remove multiplication in timestamp when committing to monitoring Jun 10, 2022
@fstagni fstagni merged commit 76aed29 into DIRACGrid:integration Jun 14, 2022
@DIRACGridBot DIRACGridBot added the sweep:ignore Prevent sweeping from being ran for this PR label Jun 14, 2022
@rupozzi rupozzi deleted the timestamp-issue branch June 27, 2022 13:02
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
sweep:ignore Prevent sweeping from being ran for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monitoring generating insane timestamp
3 participants