Debug Tree JSON Reader #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*u tree_runner.py - increase timeout from 3 to 5 seconds
*u tree_reader.py - debug method generate_from_json
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the Tree Reader JSON processing method.
The expected JSON string provided by tests was incorrect, and did not match the actual output of the Tree Command.
The JSON string is wrapped in square brackets (an array) at the top level.
This change fixes both the tests and the JSON object processing method.
It also increases the timeout on the Tree Command from 3 to 5 seconds, just in case someone wants to run Treescriptify on a large directory.