Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Removes yaml-config support #962

Merged
merged 3 commits into from
Aug 21, 2023
Merged

Removes yaml-config support #962

merged 3 commits into from
Aug 21, 2023

Conversation

cornerfarmer
Copy link
Member

No description provided.

@cla-bot cla-bot bot added the cla-signed label Aug 21, 2023
@cornerfarmer
Copy link
Member Author

cornerfarmer commented Aug 21, 2023

BlenderProcHelper result for run 524:

Done with: [amass_human_poses_python 33s, auto_shading_python 9s, basic_python 14s, blenderkit_python 20s, bop_object_on_surface_sampling_python 93s, bop_object_physics_positioning_python 121s, bop_object_pose_sampling_python 43s, bop_scene_replication_python 169s, camera_depth_of_field_python 20s, camera_object_pose_python 16s, camera_random_trajectories_python 54s, camera_sampling_python 18s, coco_annotations_python 16s, diffuse_color_image_python 18s, dust_python 29s, entity_displacement_modifier_python 15s, entity_manipulation_python 11s, front_3d_object_sampling_python 86s, front_3d_python 99s, front_3d_with_improved_mat_python 107s, git_log 1s, haven_python 22s, ikea_python 17s, kinect_azure_noise_python 15s, lens_distortion_python 15s, lens_distortion_python 12s, light_sampling_python 12s, material_manipulation_python 11s, material_randomizer_python 13s, matterport3d_python 72s, motion_blur_rolling_shutter_python 27s, motion_blur_rolling_shutter_python 25s, multi_render_python, nocs_python 18s, object_pose_sampling_python 10s, on_surface_object_sampling_python 10s, optical_flow_python 26s, physics_convex_decomposition_python 127s, physics_positioning_python 22s, pix3d_python 16s, random_backgrounds_python 17s, random_room_constructor_python 86s, replica_python 356s, scenenet_python 56s, scenenet_with_cctextures_python 58s, semantic_segmentation_python 15s, shapenet_python 20s, shapenet_with_scenenet_python 59s, shapenet_with_suncg_python 68s, spotlight_python 26s, stereo_matching_python 43s, stereo_matching_with_projector_python 143s, suncg_basic_python 33s, suncg_with_cam_sampling_python 58s, suncg_with_improved_mat_python 77s, suncg_with_object_replacer_python 64s, tests_python 15s, urdf_loading_and_manipulation_python 52s]
Done with 58 of 58 tests.
There were errors:
Unit tests output:

...........
----------------------------------------------------------------------
Ran 11 tests in 10.536s

OK

Pylint output

Expand

Messages

Module blenderproc.debug_startup (blenderproc/debug_startup.py)

Line Col. Type Symbol ID Obj Message
4 0 warning unused-import W0611
Unused Path imported from pathlib

Module blenderproc.python.loader.BopLoader (blenderproc/python/loader/BopLoader.py)

Line Col. Type Symbol ID Obj Message
54 22 warning f-string-without-interpolation W1309 load_bop_objs
Using an f-string that does not have any interpolated variables

Module blenderproc.python.loader.HavenEnvironmentLoader (blenderproc/python/loader/HavenEnvironmentLoader.py)

Line Col. Type Symbol ID Obj Message
8 0 convention wrong-import-order C0411
standard import "from typing import Union" should be placed before "import numpy as np"
15 78 convention trailing-whitespace C0303
Trailing whitespace
15 0 warning dangerous-default-value W0102 set_world_background_hdr_img
Dangerous default value [] as argument
44 0 convention trailing-whitespace C0303
Trailing whitespace
46 49 convention trailing-whitespace C0303
Trailing whitespace
48 0 convention trailing-whitespace C0303
Trailing whitespace
54 0 convention trailing-whitespace C0303
Trailing whitespace

Module blenderproc.python.utility.GlobalStorage (blenderproc/python/utility/GlobalStorage.py)

Line Col. Type Symbol ID Obj Message
1 0 convention missing-module-docstring C0114
Missing module docstring
4 0 refactor useless-object-inheritance R0205 GlobalStorage
Class 'GlobalStorage' inherits from object, can be safely removed from bases in python3
13 0 convention line-too-long C0301
Line too long (121/120)
63 35 convention consider-using-f-string C0209 GlobalStorage.init_global
Formatting a regular string which could be a f-string
79 35 convention consider-using-f-string C0209 GlobalStorage.add_to_config_before_init
Formatting a regular string which could be a f-string
98 22 convention consider-iterating-dictionary C0201 GlobalStorage.add
Consider iterating the dictionary directly instead of calling .keys()
101 31 convention consider-using-f-string C0209 GlobalStorage.add
Formatting a regular string which could be a f-string
102 0 convention line-too-long C0301
Line too long (129/120)
128 8 refactor no-else-return R1705 GlobalStorage.get
Unnecessary "else" after "return", remove the "else" and de-indent the code inside it
131 31 convention consider-using-f-string C0209 GlobalStorage.get
Formatting a regular string which could be a f-string
151 8 refactor no-else-return R1705 GlobalStorage.has_param
Unnecessary "else" after "return", remove the "else" and de-indent the code inside it
166 8 refactor no-else-return R1705 GlobalStorage.get_global_config
Unnecessary "else" after "return", remove the "else" and de-indent the code inside it

Module blenderproc.python.utility.InstallUtility (blenderproc/python/utility/InstallUtility.py)

Line Col. Type Symbol ID Obj Message
33 39 warning unused-argument W0613 InstallUtility.determine_blender_install_path
Unused argument 'user_args'

Module blenderproc.python.utility.MaterialGetter (blenderproc/python/utility/MaterialGetter.py)

Line Col. Type Symbol ID Obj Message
1 0 convention missing-module-docstring C0114
Missing module docstring
9 0 convention missing-class-docstring C0115 MaterialGetter
Missing class docstring
10 0 convention trailing-whitespace C0303
Trailing whitespace
54 44 convention consider-using-f-string C0209 MaterialGetter.perform_and_condition_check
Formatting a regular string which could be a f-string
57 0 convention line-too-long C0301
Line too long (129/120)
64 0 convention line-too-long C0301
Line too long (126/120)
72 40 convention consider-using-f-string C0209 MaterialGetter.perform_and_condition_check
Formatting a regular string which could be a f-string
81 0 convention superfluous-parens C0325
Unnecessary parens after 'not' keyword
85 0 convention superfluous-parens C0325
Unnecessary parens after 'not' keyword
89 0 convention superfluous-parens C0325
Unnecessary parens after 'not' keyword
93 48 convention consider-using-f-string C0209 MaterialGetter.perform_and_condition_check
Formatting a regular string which could be a f-string
104 0 convention superfluous-parens C0325
Unnecessary parens after 'not' keyword
108 0 convention superfluous-parens C0325
Unnecessary parens after 'not' keyword
112 0 convention superfluous-parens C0325
Unnecessary parens after 'not' keyword
116 48 convention consider-using-f-string C0209 MaterialGetter.perform_and_condition_check
Formatting a regular string which could be a f-string
138 48 convention consider-using-f-string C0209 MaterialGetter.perform_and_condition_check
Formatting a regular string which could be a f-string
150 0 convention superfluous-parens C0325
Unnecessary parens after 'not' keyword
154 0 convention superfluous-parens C0325
Unnecessary parens after 'not' keyword
158 0 convention superfluous-parens C0325
Unnecessary parens after 'not' keyword
162 48 convention consider-using-f-string C0209 MaterialGetter.perform_and_condition_check
Formatting a regular string which could be a f-string

Module blenderproc.python.utility.Utility (blenderproc/python/utility/Utility.py)

Line Col. Type Symbol ID Obj Message
12 0 warning unused-import W0611
Unused import importlib

Module blenderproc.scripts.download_haven (blenderproc/scripts/download_haven.py)

Line Col. Type Symbol ID Obj Message
89 23 warning broad-exception-caught W0718 cli.download_items
Catching too general exception Exception

Metrics

Count per types

Name Count
warning 6
convention 34
refactor 4

Count per messages

Name Count
unused-import 2
trailing-whitespace 6
dangerous-default-value 1
wrong-import-order 1
f-string-without-interpolation 1
line-too-long 4
missing-module-docstring 2
useless-object-inheritance 1
consider-using-f-string 10
consider-iterating-dictionary 1
no-else-return 3
unused-argument 1
superfluous-parens 9
missing-class-docstring 1
broad-exception-caught 1

Count per modules

Name Count
blenderproc.debug_startup 1
blenderproc.python.loader.HavenEnvironmentLoader 7
blenderproc.python.loader.BopLoader 1
blenderproc.python.utility.GlobalStorage 12
blenderproc.python.utility.InstallUtility 1
blenderproc.python.utility.MaterialGetter 20
blenderproc.python.utility.Utility 1
blenderproc.scripts.download_haven 1

Count per path

Name Count
blenderproc/debug_startup.py 1
blenderproc/python/loader/HavenEnvironmentLoader.py 7
blenderproc/python/loader/BopLoader.py 1
blenderproc/python/utility/GlobalStorage.py 12
blenderproc/python/utility/InstallUtility.py 1
blenderproc/python/utility/MaterialGetter.py 20
blenderproc/python/utility/Utility.py 1
blenderproc/scripts/download_haven.py 1
The job is still running with ids: 263190, 263191, 263192, 263193, 263194, 263195, 263196, 263197 on 8x GPU_NODE16! ⏳
Last update: 08/21/2023, 22:33:42

@cornerfarmer
Copy link
Member Author

cornerfarmer commented Aug 21, 2023

BlenderProcHelper result for run 525:

Done with: [amass_human_poses_python 35s, auto_shading_python 9s, basic_python 12s, blenderkit_python 20s, bop_object_on_surface_sampling_python 90s, bop_object_physics_positioning_python 120s, bop_object_pose_sampling_python 42s, bop_scene_replication_python 175s, camera_depth_of_field_python 20s, camera_object_pose_python 16s, camera_random_trajectories_python 53s, camera_sampling_python 20s, coco_annotations_python 14s, diffuse_color_image_python 19s, dust_python 28s, entity_displacement_modifier_python 14s, entity_manipulation_python 10s, front_3d_object_sampling_python 84s, front_3d_python 99s, front_3d_with_improved_mat_python 109s, git_log 1s, haven_python 23s, ikea_python 17s, kinect_azure_noise_python 16s, lens_distortion_python 16s, lens_distortion_python 13s, light_sampling_python 12s, material_manipulation_python 11s, material_randomizer_python 13s, matterport3d_python 70s, motion_blur_rolling_shutter_python 25s, motion_blur_rolling_shutter_python 24s, multi_render_python 252s, nocs_python 17s, object_pose_sampling_python 10s, on_surface_object_sampling_python 10s, optical_flow_python 26s, physics_convex_decomposition_python 131s, physics_positioning_python 22s, pix3d_python 16s, random_backgrounds_python 17s, random_room_constructor_python 87s, replica_python 356s, scenenet_python 54s, scenenet_with_cctextures_python 56s, semantic_segmentation_python 15s, shapenet_python 19s, shapenet_with_scenenet_python 56s, shapenet_with_suncg_python 69s, spotlight_python 31s, stereo_matching_python 43s, stereo_matching_with_projector_python 143s, suncg_basic_python 31s, suncg_with_cam_sampling_python 60s, suncg_with_improved_mat_python 79s, suncg_with_object_replacer_python 63s, tests_python 15s, urdf_loading_and_manipulation_python 51s]
Done with 58 of 58 tests.
There were errors:
Unit tests output:

...........
----------------------------------------------------------------------
Ran 11 tests in 10.335s

OK

urdf_loading_and_manipulation (main_python)

The output of urdf_loading_and_manipulation:main_python:000000_scene_gt_info_json has changed:

Expand
+ root['5'][3]['bbox_visib'][3]: 108
- root['5'][3]['bbox_visib'][3]: 107

Pylint output

Expand

Messages

Module blenderproc.debug_startup (blenderproc/debug_startup.py)

Line Col. Type Symbol ID Obj Message
4 0 warning unused-import W0611
Unused Path imported from pathlib

Module blenderproc.python.loader.BopLoader (blenderproc/python/loader/BopLoader.py)

Line Col. Type Symbol ID Obj Message
54 22 warning f-string-without-interpolation W1309 load_bop_objs
Using an f-string that does not have any interpolated variables

Module blenderproc.python.loader.HavenEnvironmentLoader (blenderproc/python/loader/HavenEnvironmentLoader.py)

Line Col. Type Symbol ID Obj Message
8 0 convention wrong-import-order C0411
standard import "from typing import Union" should be placed before "import numpy as np"
15 78 convention trailing-whitespace C0303
Trailing whitespace
15 0 warning dangerous-default-value W0102 set_world_background_hdr_img
Dangerous default value [] as argument
44 0 convention trailing-whitespace C0303
Trailing whitespace
46 49 convention trailing-whitespace C0303
Trailing whitespace
48 0 convention trailing-whitespace C0303
Trailing whitespace
54 0 convention trailing-whitespace C0303
Trailing whitespace

Module blenderproc.python.utility.GlobalStorage (blenderproc/python/utility/GlobalStorage.py)

Line Col. Type Symbol ID Obj Message
1 0 convention missing-module-docstring C0114
Missing module docstring
4 0 refactor useless-object-inheritance R0205 GlobalStorage
Class 'GlobalStorage' inherits from object, can be safely removed from bases in python3
13 0 convention line-too-long C0301
Line too long (121/120)
63 35 convention consider-using-f-string C0209 GlobalStorage.init_global
Formatting a regular string which could be a f-string
79 35 convention consider-using-f-string C0209 GlobalStorage.add_to_config_before_init
Formatting a regular string which could be a f-string
98 22 convention consider-iterating-dictionary C0201 GlobalStorage.add
Consider iterating the dictionary directly instead of calling .keys()
101 31 convention consider-using-f-string C0209 GlobalStorage.add
Formatting a regular string which could be a f-string
102 0 convention line-too-long C0301
Line too long (129/120)
128 8 refactor no-else-return R1705 GlobalStorage.get
Unnecessary "else" after "return", remove the "else" and de-indent the code inside it
131 31 convention consider-using-f-string C0209 GlobalStorage.get
Formatting a regular string which could be a f-string
151 8 refactor no-else-return R1705 GlobalStorage.has_param
Unnecessary "else" after "return", remove the "else" and de-indent the code inside it
166 8 refactor no-else-return R1705 GlobalStorage.get_global_config
Unnecessary "else" after "return", remove the "else" and de-indent the code inside it

Module blenderproc.python.utility.InstallUtility (blenderproc/python/utility/InstallUtility.py)

Line Col. Type Symbol ID Obj Message
33 39 warning unused-argument W0613 InstallUtility.determine_blender_install_path
Unused argument 'user_args'

Module blenderproc.python.utility.MaterialGetter (blenderproc/python/utility/MaterialGetter.py)

Line Col. Type Symbol ID Obj Message
1 0 convention missing-module-docstring C0114
Missing module docstring
9 0 convention missing-class-docstring C0115 MaterialGetter
Missing class docstring
10 0 convention trailing-whitespace C0303
Trailing whitespace
54 44 convention consider-using-f-string C0209 MaterialGetter.perform_and_condition_check
Formatting a regular string which could be a f-string
57 0 convention line-too-long C0301
Line too long (129/120)
64 0 convention line-too-long C0301
Line too long (126/120)
72 40 convention consider-using-f-string C0209 MaterialGetter.perform_and_condition_check
Formatting a regular string which could be a f-string
81 0 convention superfluous-parens C0325
Unnecessary parens after 'not' keyword
85 0 convention superfluous-parens C0325
Unnecessary parens after 'not' keyword
89 0 convention superfluous-parens C0325
Unnecessary parens after 'not' keyword
93 48 convention consider-using-f-string C0209 MaterialGetter.perform_and_condition_check
Formatting a regular string which could be a f-string
104 0 convention superfluous-parens C0325
Unnecessary parens after 'not' keyword
108 0 convention superfluous-parens C0325
Unnecessary parens after 'not' keyword
112 0 convention superfluous-parens C0325
Unnecessary parens after 'not' keyword
116 48 convention consider-using-f-string C0209 MaterialGetter.perform_and_condition_check
Formatting a regular string which could be a f-string
138 48 convention consider-using-f-string C0209 MaterialGetter.perform_and_condition_check
Formatting a regular string which could be a f-string
150 0 convention superfluous-parens C0325
Unnecessary parens after 'not' keyword
154 0 convention superfluous-parens C0325
Unnecessary parens after 'not' keyword
158 0 convention superfluous-parens C0325
Unnecessary parens after 'not' keyword
162 48 convention consider-using-f-string C0209 MaterialGetter.perform_and_condition_check
Formatting a regular string which could be a f-string

Module blenderproc.python.utility.Utility (blenderproc/python/utility/Utility.py)

Line Col. Type Symbol ID Obj Message
12 0 warning unused-import W0611
Unused import importlib

Module blenderproc.python.writer.BopWriterUtility (blenderproc/python/writer/BopWriterUtility.py)

Line Col. Type Symbol ID Obj Message
7 0 warning unused-import W0611
Unused import shutil
18 0 warning unused-import W0611
Unused Utility imported from blenderproc.python.utility.Utility
18 0 warning unused-import W0611
Unused resolve_path imported from blenderproc.python.utility.Utility
19 0 warning unused-import W0611
Unused dist2depth imported from blenderproc.python.postprocessing.PostProcessingUtility

Module blenderproc.python.writer.CocoWriterUtility (blenderproc/python/writer/CocoWriterUtility.py)

Line Col. Type Symbol ID Obj Message
16 0 warning unused-import W0611
Unused Utility imported from blenderproc.python.utility.Utility
91 22 error undefined-variable E0602 write_coco_annotations
Undefined variable 'segcolormap_output'
99 29 error undefined-variable E0602 write_coco_annotations
Undefined variable 'segmentation_map_output'
122 26 error undefined-variable E0602 write_coco_annotations
Undefined variable 'rgb_output'
124 75 error undefined-variable E0602 write_coco_annotations
Undefined variable 'rgb_output'

Module blenderproc.scripts.download_haven (blenderproc/scripts/download_haven.py)

Line Col. Type Symbol ID Obj Message
89 23 warning broad-exception-caught W0718 cli.download_items
Catching too general exception Exception

Metrics

Count per types

Name Count
warning 11
convention 34
refactor 4
error 4

Count per messages

Name Count
unused-import 7
trailing-whitespace 6
dangerous-default-value 1
wrong-import-order 1
f-string-without-interpolation 1
line-too-long 4
missing-module-docstring 2
useless-object-inheritance 1
consider-using-f-string 10
consider-iterating-dictionary 1
no-else-return 3
unused-argument 1
superfluous-parens 9
missing-class-docstring 1
undefined-variable 4
broad-exception-caught 1

Count per modules

Name Count
blenderproc.debug_startup 1
blenderproc.python.loader.HavenEnvironmentLoader 7
blenderproc.python.loader.BopLoader 1
blenderproc.python.utility.GlobalStorage 12
blenderproc.python.utility.InstallUtility 1
blenderproc.python.utility.MaterialGetter 20
blenderproc.python.utility.Utility 1
blenderproc.python.writer.BopWriterUtility 4
blenderproc.python.writer.CocoWriterUtility 5
blenderproc.scripts.download_haven 1

Count per path

Name Count
blenderproc/debug_startup.py 1
blenderproc/python/loader/HavenEnvironmentLoader.py 7
blenderproc/python/loader/BopLoader.py 1
blenderproc/python/utility/GlobalStorage.py 12
blenderproc/python/utility/InstallUtility.py 1
blenderproc/python/utility/MaterialGetter.py 20
blenderproc/python/utility/Utility.py 1
blenderproc/python/writer/BopWriterUtility.py 4
blenderproc/python/writer/CocoWriterUtility.py 5
blenderproc/scripts/download_haven.py 1
***The tests are done.*** Check the log:

Last update: 08/21/2023, 22:48:19

@cornerfarmer cornerfarmer merged commit 59a32b0 into main Aug 21, 2023
@cornerfarmer cornerfarmer deleted the yaml_purge branch August 21, 2023 20:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant