Add precommit config yaml and fix typos automatically #1979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, |
I have split the typos from this PR to this #1981 However, i would strongly recommend to enforce spellcheck and other checks as proposed in this PR in oder to avoid playing catch-up and get in before such things occur |
cschindlbeck
force-pushed
the
add-precommit-config-yaml
branch
from
70999c7 to
bd3c0c6
Compare
|
Rebased on top of typo fixes |
cschindlbeck
force-pushed
the
add-precommit-config-yaml
branch
from
8eb5b55 to
a4c8676
Compare
|
Anything left to do here @araffin ? |
|
related: #545 |
cschindlbeck
force-pushed
the
add-precommit-config-yaml
branch
from
a4c8676 to
a2f57c1
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a pre-commit-config yaml for the pre-commit message, fix its typos accordingly
There are two open points
Motivation and Context
Automatically check codespell in pre-commit hooks, i.e. every time you commit
Checklist