Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix tests and warnings when running locally with a GPU #2069

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Fix tests and warnings when running locally with a GPU #2069

merged 3 commits into from
Jan 7, 2025

Conversation

araffin
Copy link
Member

@araffin araffin commented Jan 7, 2025

Description

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

  • I've read the CONTRIBUTION guide (required)
  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have opened an associated PR on the SB3-Contrib repository (if necessary)
  • I have opened an associated PR on the RL-Zoo3 repository (if necessary)
  • I have reformatted the code using make format (required)
  • I have checked the codestyle using make check-codestyle and make lint (required)
  • I have ensured make pytest and make type both pass. (required)
  • I have checked that the documentation builds using make doc (required)

Note: You can run most of the checks using make commit-checks.

Note: we are using a maximum length of 127 characters per line

@araffin araffin merged commit 2b529e5 into master Jan 7, 2025
4 checks passed
@araffin araffin deleted the fix/warnings-gpu branch January 7, 2025 13:19
araffin added a commit that referenced this pull request Jan 7, 2025
@araffin
Fix tests and warnings when running locally with a GPU (#2069)
9555dd9 
* Fix test when GPU is available

* Sort file list for consistent results

* Ignore A2C warnings too
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@araffin