Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Contest listing displays "Join" where it should say "Spectate" #544

Closed
hnrgu opened this issue Feb 17, 2017 · 3 comments · Fixed by #1473 or #1765
Closed

Contest listing displays "Join" where it should say "Spectate" #544

hnrgu opened this issue Feb 17, 2017 · 3 comments · Fixed by #1473 or #1765
Labels
bug contest

Comments

@hnrgu
Copy link

hnrgu commented Feb 17, 2017

Contest listing displays "Join" even after finishing contest.

Clicking on the "Join" button results in an alert.
@kiritofeng
Copy link
Member

kiritofeng commented Feb 18, 2017 •
edited
Loading

This is because the code in site/templates/contest/list.jade does not check if you have participated in said contest

@kiritofeng kiritofeng self-assigned this Feb 18, 2017
@quantum5
Copy link
Member

Wow @kiritofeng are you anywhere near finishing this?

@kiritofeng kiritofeng removed their assignment Oct 18, 2018
Carson-Tang added a commit to Carson-Tang/site that referenced this issue Mar 28, 2020
@Carson-Tang
Replace join text with spectate if user is finished contest; fixes DM…
bad75d7 
…OJ#544
@Xyene Xyene closed this as completed in 324bb18 Mar 28, 2020
@Carson-Tang
Copy link
Member

The change from #1272 did not fix the issue as contest.is_in_contest checks whether the user is currently participating in the contest rather than if the user has participated.

@Xyene Xyene reopened this Apr 4, 2020
Ninjaclasher added a commit to Ninjaclasher/site that referenced this issue Jun 30, 2020
@Ninjaclasher
Revert "Replace join text with spectate if user is finished contest; f…
14e362f 
…ixes DMOJ#544"

This reverts commit 324bb18.
Ninjaclasher added a commit to Ninjaclasher/site that referenced this issue Jul 1, 2020
@Ninjaclasher
Revert "Replace join text with spectate if user is finished contest; f…
b3a1593 
…ixes DMOJ#544"

This reverts commit 324bb18.
@Ninjaclasher Ninjaclasher mentioned this issue Jul 1, 2020
Merged
quantum5 pushed a commit that referenced this issue Jul 1, 2020
@Ninjaclasher
Revert "Replace join text with spectate if user is finished contest; f…
9858c8b 
…ixes #544" (#1473)

This reverts commit 324bb18.
@quantum5 quantum5 reopened this Jul 1, 2020
outloudvi pushed a commit to SchOJ/site that referenced this issue Oct 27, 2020
@Carson-Tang @outloudvi
Replace join text with spectate if user is finished contest; fixes DM…
d116d30 
…OJ#544
outloudvi pushed a commit to SchOJ/site that referenced this issue Oct 27, 2020
@Ninjaclasher @outloudvi
Revert "Replace join text with spectate if user is finished contest; f…
3a44b38 
…ixes DMOJ#544" (DMOJ#1473)

This reverts commit 324bb18.
@int-y1 int-y1 mentioned this issue Sep 8, 2021
Merged
malbareda pushed a commit to malbareda/JOEL-web that referenced this issue Jan 4, 2024
@Carson-Tang @Xyene
Replace join text with spectate if user is finished contest; fixes DM…
9f58aa8 
…OJ#544
malbareda pushed a commit to malbareda/JOEL-web that referenced this issue Jan 4, 2024
@Ninjaclasher
Revert "Replace join text with spectate if user is finished contest; f…
903a753 
…ixes DMOJ#544" (DMOJ#1473)

This reverts commit 324bb18.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug contest
Projects
None yet
Milestone
No milestone
5 participants
@quantum5 @Xyene @hnrgu @kiritofeng @Carson-Tang