Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Vertically align checkbox input type #1465

Merged
merged 1 commit into from
Jun 24, 2020
Merged

Vertically align checkbox input type #1465

merged 1 commit into from
Jun 24, 2020

Conversation

fluix-dev
Copy link
Contributor

This makes the checkbox input types vertically aligned.

Note: I originally tested this by just using the development console of Firefox, then trying to edit the necessary file and./make_style.sh. Unfortunately, I can't get it to add the css to the processed file and I'm not sure why. Perhaps I'm doing something wrong, either with generating styles or this actual code.

Before

screenshot_20200621_032356
screenshot_20200621_032348
screenshot_20200621_032345

After

screenshot_20200621_032606
screenshot_20200621_032546
screenshot_20200621_032540

@codecov-commenter
Copy link

Codecov Report

Merging #1465 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1465   +/-   ##
=======================================
  Coverage   45.85%   45.85%           
=======================================
  Files         208      208           
  Lines       11966    11966           
=======================================
  Hits         5487     5487           
  Misses       6479     6479           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06b3ff4...b18ab49. Read the comment docs.

@fluix-dev
Copy link
Contributor Author

Thank you @Carson-Tang for testing, the ./make_style.sh works and I've tested the output css.

Copy link
Member

@Xyene Xyene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Xyene Xyene merged commit d4380b6 into DMOJ:master Jun 24, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants