Correctly pluralize assignees on ticket page #1555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1555 +/- ##
=======================================
Coverage 46.10% 46.10%
=======================================
Files 210 210
Lines 12074 12074
=======================================
Hits 5567 5567
Misses 6507 6507 Continue to review full report at Codecov.
|
fluix-dev
reviewed
Sep 30, 2020
templates/ticket/ticket.html
Outdated
| @@ -357,7 +357,13 @@ | |||
| </div> | |||
| </div> | |||
| <div class="info-box"> | |||
| <div class="info-title">{{ _('Assignees') }}</div> | |||
| <div class="info-title"> | |||
| {% trans trimmed count=assignees|length, singular=_("Assignee"), pluralized=_("Assignees") %} | |||
There was a problem hiding this comment.
I tried something similar but the resulting change broke the translations :/
EDIT: I see what I've been doing wrong. Just updated it to the cleaner method. Thank you!
|
Yikes I closed this on accident, I'm going to reopen this again |
zecookiez
force-pushed
the
fix-ticket-assignee-pluralization
branch
from
5ff6a18 to
3c47fd3
Compare
quantum5
approved these changes
Sep 30, 2020
quantum5
changed the title
outloudvi
pushed a commit
to SchOJ/site
that referenced
this pull request
Oct 27, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also tested the change with the i18n translations and it works properly.
Not sure whether this is the best way to write it. If there's a better way to change this please let me know :(