Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove share to Google Plus on Contests and Blogs #1583

Merged
merged 1 commit into from
Jan 18, 2021

Conversation

kevinjycui
Copy link
Contributor

Not a very important PR but since Google shut down consumer Google+ accounts 2 years ago, I think the "share to Google+ button" on blogs and contests can be removed (unless DMOJ has an organisational Google+ community in which case this PR can be closed and ignored).

@codecov-io
Copy link

Codecov Report

Merging #1583 (3061bb8) into master (707c015) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1583   +/-   ##
=======================================
  Coverage   46.05%   46.05%           
=======================================
  Files         213      213           
  Lines       12145    12145           
=======================================
  Hits         5593     5593           
  Misses       6552     6552           
Impacted Files Coverage Δ
judge/jinja2/social.py 72.22% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 707c015...3061bb8. Read the comment docs.

Copy link
Contributor

@fluix-dev fluix-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and makes sense, thanks!

@Xyene Xyene merged commit bb13f4f into DMOJ:master Jan 18, 2021
@kevinjycui kevinjycui deleted the remove-google-plus branch January 20, 2021 01:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants