Don't rate contests which have not finished yet #1591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ninjaclasher
force-pushed
the
rating-fix
branch
from
ecefac7 to
0402623
Compare
quantum5
approved these changes
Feb 7, 2021
|
Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1590.
After this commit, contests which have not ended cannot be rated. We should probably make sure there isn't a case where someone might want to rate an ongoing contest.
On a side note, should we hide (or maybe grey out) the
Ratebutton if the contest has not ended yet? It might be confusing if clicking the rate button does nothing for an ongoing contest.