Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove rate button for ongoing contests; #1592 #1599

Merged
merged 1 commit into from
Feb 22, 2021

Conversation

Carson-Tang
Copy link
Member

Fixes #1592.

@codecov-io
Copy link

Codecov Report

Merging #1599 (6538295) into master (c2573f5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1599   +/-   ##
=======================================
  Coverage   46.03%   46.03%           
=======================================
  Files         213      213           
  Lines       12146    12146           
=======================================
  Hits         5592     5592           
  Misses       6554     6554           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2573f5...6538295. Read the comment docs.

Copy link
Member

@kiritofeng kiritofeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Ninjaclasher Ninjaclasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current change looks good, but I think you should also 404 here.

@Carson-Tang Carson-Tang force-pushed the disable-rate-ongoing-contest branch 2 times, most recently from 534c0ae to f83f09d Compare February 18, 2021 03:37
@Carson-Tang
Copy link
Member Author

Current change looks good, but I think you should also 404 here.

Added the changes suggested.

@Carson-Tang Carson-Tang force-pushed the disable-rate-ongoing-contest branch from f83f09d to 7dbfd5e Compare February 18, 2021 04:41
Copy link
Member

@Xyene Xyene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xyene Xyene merged commit 8c64337 into DMOJ:master Feb 22, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable Rate button for ongoing contests...
5 participants