Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add problem visibility to APIProblemList #1661

Merged
merged 1 commit into from
Apr 29, 2021
Merged

Add problem visibility to APIProblemList #1661

merged 1 commit into from
Apr 29, 2021

Conversation

jtyliu
Copy link
Contributor

@jtyliu jtyliu commented Apr 29, 2021

This is a quite needed feature for my discord bot JOMD. Assuming if we link an api token with the bot there's no way to differentiate between public problems, problems within an organization (say olympiads) and private problems. This mean accidentally leaking problems without the appropriate information.

Before the solution was to query every problem for the appropriate information, meaning we would have to send a request for every problem detail.

This pr means to add the appropriate info to the problem list api so the solution above is not needed.

@codecov-commenter
Copy link

Codecov Report

Merging #1661 (99665cd) into master (0f9b776) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1661   +/-   ##
=======================================
  Coverage   46.25%   46.25%           
=======================================
  Files         215      215           
  Lines       12282    12282           
=======================================
  Hits         5681     5681           
  Misses       6601     6601           
Impacted Files Coverage Δ
judge/views/api/api_v2.py 47.77% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f9b776...99665cd. Read the comment docs.

Copy link
Member

@Ninjaclasher Ninjaclasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also open a PR in DMOJ/docs with the appropriate doc changes?

jtyliu added a commit to jtyliu/docs that referenced this pull request Apr 29, 2021
@WallE256 WallE256 self-requested a review April 29, 2021 16:29
WallE256 pushed a commit to DMOJ/docs that referenced this pull request Apr 29, 2021
@WallE256 WallE256 merged commit 6b7d629 into DMOJ:master Apr 29, 2021
@jtyliu jtyliu deleted the patch-1 branch April 29, 2021 16:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants