Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Filter contest submissions properly in live updates #1701

Merged
merged 2 commits into from
May 30, 2021

Conversation

Ninjaclasher
Copy link
Member

Fixes #1688.

@codecov-commenter
Copy link

codecov-commenter commented May 29, 2021

Codecov Report

Merging #1701 (4dea36f) into master (775b25e) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1701      +/-   ##
==========================================
- Coverage   46.39%   46.38%   -0.01%     
==========================================
  Files         217      217              
  Lines       12360    12361       +1     
==========================================
  Hits         5734     5734              
- Misses       6626     6627       +1     
Impacted Files Coverage Δ
judge/bridge/judge_handler.py 0.00% <ø> (ø)
judge/views/submission.py 32.17% <0.00%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 775b25e...4dea36f. Read the comment docs.

@kiritofeng kiritofeng requested a review from quantum5 May 30, 2021 07:09
Copy link
Member

@quantum5 quantum5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good.

Co-authored-by: Guanzhong Chen <quantum2048@gmail.com>
@Ninjaclasher Ninjaclasher requested a review from quantum5 May 30, 2021 14:35
@quantum5 quantum5 merged commit aea5fbd into DMOJ:master May 30, 2021
@Ninjaclasher Ninjaclasher deleted the live-update-contest branch May 31, 2021 03:33
leduythuccs pushed a commit to VNOI-Admin/OJ that referenced this pull request Jun 7, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The submission list of a contest shows non-contest submissions because of dynamic updating
3 participants