Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make TOTP enable/disable views mobile friendly #1714

Merged
merged 1 commit into from
Jun 6, 2021

Conversation

Ninjaclasher
Copy link
Member

The views were practically unusable on mobile before without forcing desktop mode.

Before (on a small width screen):
image
image

Note: you cannot scroll to the left in either of the views.

After:
image
image

The views on a larger screen are almost identical. The only changes are that the form is now properly centred and this:
Before:
image
After:
image

Note that in the after screenshot, the text still wraps at 700px (not sure why it wraps early in the before screenshot).

@codecov-commenter
Copy link

Codecov Report

Merging #1714 (5435536) into master (36ea904) will increase coverage by 0.03%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1714      +/-   ##
==========================================
+ Coverage   46.38%   46.41%   +0.03%     
==========================================
  Files         217      217              
  Lines       12386    12400      +14     
==========================================
+ Hits         5745     5756      +11     
- Misses       6641     6644       +3     
Impacted Files Coverage Δ
judge/views/two_factor.py 39.75% <ø> (+0.70%) ⬆️
judge/signals.py 64.19% <20.00%> (-2.91%) ⬇️
judge/models/profile.py 91.27% <80.00%> (-0.34%) ⬇️
judge/admin/profile.py 62.22% <87.50%> (+1.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c363a38...5435536. Read the comment docs.

@quantum5 quantum5 merged commit 6aaf456 into DMOJ:master Jun 6, 2021
@Ninjaclasher Ninjaclasher deleted the totp-view-mobile branch March 20, 2022 22:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants