Prevent the reuse of TOTP authentication codes #1720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We store the timecodes in an IntegerField, which is guaranteed to support values up to 2147483647. This is okay because timecodes are Unix time divided by 30, so it supports values up to the year 4011. This fixes #1692.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We store the timecodes in an IntegerField, which is guaranteed to support values up to 2147483647. This is okay because timecodes are Unix time divided by 30, so it supports values up to the year 4011.
This fixes #1692.
Ideally, we'd add a unit test that attempts to verify the same code twice, then mock change the time and see that it does indeed validate with the new code.