Remove duplicated and unused manifest.json
#1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file is a duplicate of `resources/icons/manifest.json`, and shouldn't be used. The one in `resources/icons/manifest.json` should be used, and is the one used if the site setup documentation is followed.
Codecov Report
@@ Coverage Diff @@
## master #1735 +/- ##
=======================================
Coverage 46.50% 46.50%
=======================================
Files 220 220
Lines 12445 12445
=======================================
Hits 5787 5787
Misses 6658 6658 Continue to review full report at Codecov.
|
quantum5
approved these changes
Jun 26, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file is a duplicate of
resources/icons/manifest.json, andshouldn't be used. The one in
resources/icons/manifest.jsonshould be used, and is the one used if the site setup documentation
is followed.
It looks like this file was misplaced in #411, and it looked as if the file was missing, so was duplicated (in the correct directory) in 6532991.