Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Implement user display name override #1747

Merged
merged 1 commit into from
Aug 10, 2021
Merged

Conversation

quantum5
Copy link
Member

@quantum5 quantum5 commented Aug 9, 2021

Fixes #1745.

@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2021

Codecov Report

Merging #1747 (beb20d8) into master (e86c114) will increase coverage by 0.02%.
The diff coverage is 46.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1747      +/-   ##
==========================================
+ Coverage   46.49%   46.52%   +0.02%     
==========================================
  Files         220      221       +1     
  Lines       12454    12461       +7     
==========================================
+ Hits         5791     5797       +6     
- Misses       6663     6664       +1     
Impacted Files Coverage Δ
judge/admin/profile.py 62.22% <ø> (ø)
judge/views/contests.py 29.96% <ø> (ø)
judge/views/select2.py 50.74% <0.00%> (ø)
judge/views/submission.py 32.17% <0.00%> (ø)
judge/views/user.py 38.53% <ø> (ø)
judge/models/profile.py 86.84% <66.66%> (-0.33%) ⬇️
judge/migrations/0122_username_display_override.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e86c114...beb20d8. Read the comment docs.

@kiritofeng
Copy link
Member

@quantum5 quantum5 force-pushed the display-name-override branch from 498a341 to 61e8f8c Compare August 9, 2021 02:48
@quantum5 quantum5 force-pushed the display-name-override branch from 61e8f8c to beb20d8 Compare August 9, 2021 03:06
@quantum5
Copy link
Member Author

quantum5 commented Aug 9, 2021

@kiritofeng fixed tickets, not sure what you mean about author, since it appears to work on the problem page.

Copy link
Member

@kiritofeng kiritofeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; I guess the thing about problem authors might've been some caching nonsense.

Copy link
Member

@Ninjaclasher Ninjaclasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but do we want to support filtering by the override in the select2 widget and profile admin?

@quantum5 quantum5 merged commit 64da46b into master Aug 10, 2021
@quantum5 quantum5 deleted the display-name-override branch August 10, 2021 01:17
leduythuccs pushed a commit to VNOI-Admin/OJ that referenced this pull request Nov 30, 2021
leduythuccs pushed a commit to VNOI-Admin/OJ that referenced this pull request Dec 1, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for user display name overrides
4 participants