-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Implement user display name override #1747
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1747 +/- ##
==========================================
+ Coverage 46.49% 46.52% +0.02%
==========================================
Files 220 221 +1
Lines 12454 12461 +7
==========================================
+ Hits 5791 5797 +6
- Misses 6663 6664 +1
Continue to review full report at Codecov.
|
Doesn't override problem author, nor https://github.com/DMOJ/online-judge/blob/master/templates/ticket/message.html#L5 |
498a341
to
61e8f8c
Compare
61e8f8c
to
beb20d8
Compare
@kiritofeng fixed tickets, not sure what you mean about author, since it appears to work on the problem page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; I guess the thing about problem authors might've been some caching nonsense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, but do we want to support filtering by the override in the select2 widget and profile admin?
Cherry-pick from DMOJ/online-judge#1747
Cherry-pick from DMOJ/online-judge#1747
Fixes #1745.