Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

For DQ'ed contest participations, set cumtime to zero unconditionally. #1752

Merged
merged 1 commit into from
Aug 18, 2021

Conversation

xiaowuc1
Copy link
Contributor

Disqualified participations preserve the old cumtime value which results in not all disqualified participations sharing the same rank. Having all of these be equal should force disqualified participations to share the same rank, which is a more intuitive ranking.

@codecov-commenter
Copy link

Codecov Report

Merging #1752 (d1b2fdd) into master (0c009fa) will increase coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1752      +/-   ##
==========================================
+ Coverage   46.03%   46.23%   +0.19%     
==========================================
  Files         213      222       +9     
  Lines       12159    12613     +454     
==========================================
+ Hits         5597     5831     +234     
- Misses       6562     6782     +220     
Impacted Files Coverage Δ
judge/models/contest.py 95.49% <100.00%> (+0.16%) ⬆️
judge/views/ranked_submission.py 37.25% <0.00%> (-7.75%) ⬇️
judge/models/profile.py 86.84% <0.00%> (-5.33%) ⬇️
judge/forms.py 44.32% <0.00%> (-3.98%) ⬇️
judge/signals.py 64.19% <0.00%> (-3.81%) ⬇️
judge/jinja2/social.py 68.42% <0.00%> (-3.81%) ⬇️
judge/views/ticket.py 39.44% <0.00%> (-1.12%) ⬇️
judge/social_auth.py 41.55% <0.00%> (-0.75%) ⬇️
judge/views/register.py 50.70% <0.00%> (-0.69%) ⬇️
judge/views/submission.py 32.17% <0.00%> (-0.49%) ⬇️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c009fa...d1b2fdd. Read the comment docs.

@quantum5 quantum5 merged commit 32fbbc1 into DMOJ:master Aug 18, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants