Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

For DQ'ed contest participations, set tiebreaker to zero unconditionally. #1753

Merged
merged 1 commit into from
Aug 18, 2021

Conversation

xiaowuc1
Copy link
Contributor

Disqualified participations preserve the old tiebreaker value which results in not all disqualified participations sharing the same rank. Having all of these be equal should force disqualified participations to share the same rank, which is a more intuitive ranking.

@codecov-commenter
Copy link

Codecov Report

Merging #1753 (d032e3d) into master (32fbbc1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1753   +/-   ##
=======================================
  Coverage   46.23%   46.23%           
=======================================
  Files         222      222           
  Lines       12613    12614    +1     
=======================================
+ Hits         5831     5832    +1     
  Misses       6782     6782           
Impacted Files Coverage Δ
judge/models/contest.py 95.50% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32fbbc1...d032e3d. Read the comment docs.

@quantum5 quantum5 merged commit 97d194d into DMOJ:master Aug 18, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants