Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Implement hardcore 2FA mode #1762

Merged
merged 1 commit into from
Sep 5, 2021
Merged

Implement hardcore 2FA mode #1762

merged 1 commit into from
Sep 5, 2021

Conversation

quantum5
Copy link
Member

@quantum5 quantum5 commented Sep 4, 2021

Example UI:

2FA enable

Also, the message on the 2FA page prompting to contact admins when losing both scratch codes and second factor is removed in this mode.

Fixes #1761.

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2021

Codecov Report

Merging #1762 (aa0eb66) into master (10365cb) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1762      +/-   ##
==========================================
- Coverage   46.16%   46.16%   -0.01%     
==========================================
  Files         223      223              
  Lines       12658    12664       +6     
==========================================
+ Hits         5844     5846       +2     
- Misses       6814     6818       +4     
Impacted Files Coverage Δ
judge/views/two_factor.py 39.18% <20.00%> (-0.58%) ⬇️
dmoj/settings.py 97.70% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10365cb...aa0eb66. Read the comment docs.

Copy link
Member

@Xyene Xyene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

@quantum5 quantum5 merged commit b81c05c into master Sep 5, 2021
@quantum5 quantum5 deleted the hardcore-2fa branch September 5, 2021 04:02
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add hardcore 2FA mode
4 participants