Remove uses of Django 3.0 deprecations #1789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just an alias of urllib.parse.quote on Python 3, and it's deprecated starting Django 3.0.
This is just an alias of django.utils.translation.gettext on Python 3, and it's deprecated starting Django 3.0.
Codecov Report
@@ Coverage Diff @@
## master #1789 +/- ##
=======================================
Coverage 46.20% 46.20%
=======================================
Files 223 223
Lines 12676 12676
=======================================
Hits 5857 5857
Misses 6819 6819
Continue to review full report at Codecov.
|
This is just an alias of django.utils.translation.ngettext on Python 3, and it's deprecated starting Django 3.0.
quantum5
force-pushed
the
django-3-deprecation
branch
from
f417b53 to
520d21d
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes references to
django.utils.http.urlquote,django.utils.translation.ugettext,django.utils.translation.ungettext, which are aliases of other functions on Python 3. It's okay to drop them now since we don't need Python 2 support, and we want to discourage these being cargo culted.