Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix race condition in PDF math rendering #1810

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

int-y1
Copy link
Contributor

@int-y1 int-y1 commented Oct 20, 2021

networkidle0 existed since v0.13.0.

Some background:

  • MathJax didn't provide a way to tell if the math fonts have fully loaded.
    • For example, MathJax's typesetPromise creates the DOM elements without any knowledge of fonts.
  • Puppeteer creates the PDF too early, so the math may not have a font yet.

@codecov-commenter
Copy link

Codecov Report

Merging #1810 (b65004d) into master (8e5b6b0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1810   +/-   ##
=======================================
  Coverage   46.13%   46.13%           
=======================================
  Files         223      223           
  Lines       12698    12698           
=======================================
  Hits         5858     5858           
  Misses       6840     6840           
Impacted Files Coverage Δ
judge/pdf_problems.py 37.66% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e5b6b0...b65004d. Read the comment docs.

@quantum5 quantum5 merged commit a01b174 into DMOJ:master Oct 20, 2021
@int-y1 int-y1 deleted the fix-puppeteer-math branch October 20, 2021 05:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants