Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Upgrade to Django 3.2 #1811

Merged
merged 4 commits into from
Oct 30, 2022
Merged

Upgrade to Django 3.2 #1811

merged 4 commits into from
Oct 30, 2022

Conversation

quantum5
Copy link
Member

These are the changes required to get the test site to start. We should probably do a far more thorough testing with a database dump import before we deploy this on prod.

@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2021

Codecov Report

Base: 46.50% // Head: 46.47% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (3abd6c9) compared to base (b676a49).
Patch coverage: 16.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1811      +/-   ##
==========================================
- Coverage   46.50%   46.47%   -0.03%     
==========================================
  Files         236      236              
  Lines       13104    13106       +2     
==========================================
- Hits         6094     6091       -3     
- Misses       7010     7015       +5     
Impacted Files Coverage Δ
dmoj_install_pymysql.py 0.00% <0.00%> (ø)
judge/utils/raw_sql.py 28.98% <0.00%> (-0.87%) ⬇️
judge/widgets/select2.py 56.66% <0.00%> (ø)
judge/admin/profile.py 62.22% <100.00%> (ø)
django_2_2_pymysql_patch.py 42.85% <0.00%> (-42.86%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Riolku
Copy link
Contributor

Riolku commented Mar 31, 2022

FWIW, the changes look sane, and clicking around on my test site didn't yield anything scary.

I did ~10 minutes of clicking, submitted, event server still works, admin actions seem to work, Celery still works, I ran a batch-rejudge and rescore, tried saving models, didn't see anything strange on Problems or Contests.

@quantum5 quantum5 force-pushed the django-3.2 branch 3 times, most recently from 3803172 to 3327c12 Compare April 15, 2022 02:37
@int-y1
Copy link
Contributor

int-y1 commented Jun 15, 2022

dmoj-wpadmin looks a bit different.

Django 2.2: pic1

Django 3.2: pic2

@Xyene Xyene marked this pull request as ready for review October 30, 2022 20:54
Copy link
Member

@Xyene Xyene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's go

@Xyene Xyene merged commit 546f9e5 into master Oct 30, 2022
@Xyene Xyene deleted the django-3.2 branch October 30, 2022 20:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants