add view_contest_submissions field
#1860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Riolku
force-pushed
the
see-scoreboard-subs
branch
from
d31f8f4 to
e815210
Compare
|
Updated: also adds a toggle for testers to see in-contest submissions, and renamed migration to be more useful. |
Codecov Report
@@ Coverage Diff @@
## master #1860 +/- ##
==========================================
+ Coverage 46.16% 46.18% +0.02%
==========================================
Files 228 229 +1
Lines 13011 13018 +7
==========================================
+ Hits 6006 6013 +7
Misses 7005 7005
Continue to review full report at Codecov.
|
Riolku
force-pushed
the
see-scoreboard-subs
branch
from
e815210 to
c3e46eb
Compare
|
Re-ordered query parameters in submission queryset, unsure if it matters. |
kiritofeng
requested changes
Feb 26, 2022
Riolku
force-pushed
the
see-scoreboard-subs
branch
2 times, most recently
from
7bc8084 to
936ffa3
Compare
Riolku
force-pushed
the
see-scoreboard-subs
branch
from
936ffa3 to
b082f22
Compare
kiritofeng
approved these changes
Feb 26, 2022
quantum5
approved these changes
Feb 26, 2022
quantum5
reviewed
Feb 26, 2022
| @@ -91,6 +93,10 @@ class Contest(models.Model): | |||
| view_contest_scoreboard = models.ManyToManyField(Profile, verbose_name=_('view contest scoreboard'), blank=True, | |||
| related_name='view_contest_scoreboard', | |||
| help_text=_('These users will be able to view the scoreboard.')) | |||
| view_contest_submissions = models.ManyToManyField(Profile, verbose_name=('can see contest submissions'), blank=True, | |||
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overrides and closes #1695. It is likely better to have a dedicated field for this instead of reusing an existing field.