Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add spectator to contests #1869

Merged
merged 1 commit into from
Feb 26, 2022
Merged

Add spectator to contests #1869

merged 1 commit into from
Feb 26, 2022

Conversation

Riolku
Copy link
Contributor

@Riolku Riolku commented Feb 25, 2022

Closes #1750. Only additional change is the renaming of related names for authors, curators and testers on the Contest model, to better match the Problem model.

@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2022

Codecov Report

Merging #1869 (bc82c3c) into master (d1c41e0) will increase coverage by 0.05%.
The diff coverage is 73.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1869      +/-   ##
==========================================
+ Coverage   46.18%   46.24%   +0.05%     
==========================================
  Files         230      231       +1     
  Lines       13031    13052      +21     
==========================================
+ Hits         6019     6036      +17     
- Misses       7012     7016       +4     
Impacted Files Coverage Δ
judge/admin/contest.py 43.45% <ø> (ø)
judge/models/tests/util.py 97.65% <ø> (ø)
judge/views/contests.py 29.23% <14.28%> (-0.09%) ⬇️
judge/migrations/0131_spectate_contests.py 100.00% <100.00%> (ø)
judge/models/contest.py 96.20% <100.00%> (+0.07%) ⬆️
judge/models/tests/test_contest.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1c41e0...bc82c3c. Read the comment docs.

@Riolku
Copy link
Contributor Author

Riolku commented Feb 26, 2022

Updated as requested.

@Riolku
Copy link
Contributor Author

Riolku commented Feb 26, 2022

Rename migration to be more useful.

@Riolku Riolku force-pushed the spectate-contest branch 4 times, most recently from 2f63e69 to 41c08d9 Compare February 26, 2022 08:52
Closes DMOJ#1750. Only additional change is the renaming of related names
for authors, curators and testers on the Contest model, to better match
the Problem model.
@quantum5 quantum5 merged commit 2367b81 into DMOJ:master Feb 26, 2022
@Riolku Riolku deleted the spectate-contest branch February 26, 2022 08:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add real spectator support to contests
4 participants