Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Compare i18n changes with correct branch #1884

Merged
merged 4 commits into from
Mar 6, 2022

Conversation

int-y1
Copy link
Contributor

@int-y1 int-y1 commented Mar 6, 2022

I suspect this workflow compares with master. This led to meaningless changes such as
https://github.com/DMOJ/online-judge/compare/6b6f3d1..f47a6ab

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2022

Codecov Report

Merging #1884 (6fdd5eb) into master (0a8e3cf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1884   +/-   ##
=======================================
  Coverage   46.24%   46.24%           
=======================================
  Files         231      231           
  Lines       13054    13054           
=======================================
  Hits         6037     6037           
  Misses       7017     7017           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a8e3cf...6fdd5eb. Read the comment docs.

Co-authored-by: Guanzhong Chen <quantum2048@gmail.com>
Copy link
Member

@quantum5 quantum5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one way to find out if this actually works.

@quantum5 quantum5 merged commit 9d29b04 into DMOJ:master Mar 6, 2022
@int-y1 int-y1 deleted the reduce-i18n-spam branch March 6, 2022 04:23
hieplpvip pushed a commit to VNOI-Admin/OJ that referenced this pull request Apr 17, 2022
Co-authored-by: Quantum <quantum2048@gmail.com>
hieplpvip pushed a commit to VNOI-Admin/OJ that referenced this pull request Apr 20, 2022
Co-authored-by: Quantum <quantum2048@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants