Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fetch all branches in GitHub action #1885

Merged
merged 1 commit into from
Mar 7, 2022
Merged

Conversation

int-y1
Copy link
Contributor

@int-y1 int-y1 commented Mar 7, 2022

origin/update-i18n wasn't fetched, so the action went with i18n_head=HEAD. To fix this, fetch all branches.

@codecov-commenter
Copy link

Codecov Report

Merging #1885 (bef1dc7) into master (9d29b04) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1885   +/-   ##
=======================================
  Coverage   46.24%   46.24%           
=======================================
  Files         231      231           
  Lines       13054    13054           
=======================================
  Hits         6037     6037           
  Misses       7017     7017           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d29b04...bef1dc7. Read the comment docs.

Copy link
Member

@Ninjaclasher Ninjaclasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@quantum5 quantum5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one way to find out. I suspect this is not the end of it: it'll probably close the PR if no file has material change. I think you know what to do in that case: if no file went down the changed path, git reset --hard "$i18n_head".

@quantum5 quantum5 merged commit c93db56 into DMOJ:master Mar 7, 2022
@int-y1 int-y1 deleted the fix-update-i18n-v2 branch March 7, 2022 02:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants