Updated activation_email.html to solve Issue #560 #1916
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Images of new email design, disregard clutter from {} elements |
|
Updated images: |
int-y1
suggested changes
Apr 15, 2022
| <i style="color: white">If you have problems activating your account, feel free to send us an email at <a href="mailto:{{ SITE_ADMIN_EMAIL }}" style="color: white">{{ SITE_ADMIN_EMAIL }}</a>.</i> | ||
| <br> | ||
| {% else %} | ||
| <p style="color: white">See you soon!</p> |
There was a problem hiding this comment.
I don't see a reason to have See you soon! in both the if and else branches. Just put it before the if-statement.
Also, this white text doesn't work.
| Please click on the following link to activate your account: | ||
| <p style="margin-left:1em"> | ||
| <a href="http://{{ site.domain }}/accounts/activate/{{ activation_key }}/">http://{{ site.domain }}/accounts/activate/{{ activation_key }}</a> | ||
| </p> | ||
|
|
| <div style="padding: 1em;"> | ||
| <br> | ||
| <div> | ||
| <img style="display:table;margin-left: auto;margin-right: auto;"src="https://avatars1.githubusercontent.com/u/6934864?v=3&s=101" width="35%" height="30%"> |
There was a problem hiding this comment.
width="35%" height="30%" creates a bad aspect ratio.
There was a problem hiding this comment.
Try using max-width and max-height in the style.
| <br> | ||
| <p>Please click on the following link to activate your account:</p> | ||
| <p style="margin-left:1em"> | ||
| <a href="http://{{ site.domain }}/accounts/activate/{{ activation_key }}/">http://{{ site.domain }}/accounts/activate/{{ activation_key }}</a> |
There was a problem hiding this comment.
https is more common nowadays.
| <p style="margin-left:1em"> | ||
| <a href="http://{{ site.domain }}/accounts/activate/{{ activation_key }}/">http://{{ site.domain }}/accounts/activate/{{ activation_key }}</a> | ||
| </p> | ||
| <i>Alternatively, you can reply to this message to activate your account</i> |
int-y1
reviewed
Apr 15, 2022
| <pre style="margin-left:1em"> | ||
| {{ activation_key }} | ||
| </pre> | ||
| <h1 style="font-size:30px;display:inline;vertical-align: middle">Welcome to DMOJ!</h1> |
There was a problem hiding this comment.
Use {{ SITE_NAME }}, not DMOJ
|
Superseded by #2028. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.