Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Clean up i18n in __str__ #1932

Merged
merged 2 commits into from
May 20, 2022
Merged

Clean up i18n in __str__ #1932

merged 2 commits into from
May 20, 2022

Conversation

int-y1
Copy link
Contributor

@int-y1 int-y1 commented Apr 30, 2022

This affects the following admin pages:

Home › Online Judge › Classes › Foo Class in DMOJ: Modern Online Judge
Home › Online Judge › Comments › b:1 by admin
Home › Online Judge › Contest participations › d in Fake Contest 111
Home › Online Judge › Submissions › Submission 12 of testpdf2 by admin

SubmissionSource.__str__ was tested by visiting a submission.

WebAuthnCredential.__str__ was tested by visiting a user profile.

@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2022

Codecov Report

Merging #1932 (0b906c2) into master (8b29591) will not change coverage.
The diff coverage is 33.33%.

@@           Coverage Diff           @@
##           master    #1932   +/-   ##
=======================================
  Coverage   46.41%   46.41%           
=======================================
  Files         235      235           
  Lines       13107    13107           
=======================================
  Hits         6084     6084           
  Misses       7023     7023           
Impacted Files Coverage Δ
judge/models/comment.py 39.61% <0.00%> (ø)
judge/models/profile.py 81.97% <0.00%> (ø)
judge/models/contest.py 96.20% <25.00%> (ø)
judge/models/submission.py 90.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b29591...0b906c2. Read the comment docs.

Copy link
Member

@quantum5 quantum5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM. Note that __str__ is really only used in the admin.

Copy link
Member

@Ninjaclasher Ninjaclasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@quantum5 quantum5 merged commit 3e5be16 into DMOJ:master May 20, 2022
@int-y1 int-y1 deleted the fix-str branch May 20, 2022 00:47
int-y1 added a commit to lakshy-gupta/online-judge that referenced this pull request Jun 8, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants