Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix filters that break i18n #1939

Merged
merged 2 commits into from
Jul 18, 2022
Merged

Fix filters that break i18n #1939

merged 2 commits into from
Jul 18, 2022

Conversation

int-y1
Copy link
Contributor

@int-y1 int-y1 commented May 21, 2022

These issues were found with git grep "_(.*=.*|"

  • Change as_countdown to a registry.function. Fix issues with |timedelta. Fix pp messages.
  • Test that all affected pages still work properly.
  • Test that makemessages can find the i18n strings:
python manage.py makemessages -l en -e py,html,txt
git diff upstream/update-i18n -- locale/en/LC_MESSAGES/django.po

@codecov-commenter
Copy link

codecov-commenter commented May 21, 2022

Codecov Report

Merging #1939 (9782861) into master (966b37d) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1939   +/-   ##
=======================================
  Coverage   46.46%   46.46%           
=======================================
  Files         236      236           
  Lines       13114    13114           
=======================================
  Hits         6093     6093           
  Misses       7021     7021           
Impacted Files Coverage Δ
judge/jinja2/timedelta.py 58.82% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 966b37d...9782861. Read the comment docs.

Copy link
Member

@Ninjaclasher Ninjaclasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Xyene Xyene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Xyene Xyene merged commit ef976aa into DMOJ:master Jul 18, 2022
@int-y1 int-y1 deleted the i18n-pipe branch July 25, 2022 06:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants