Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve password reset email #1945

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Improve password reset email #1945

merged 1 commit into from
Jul 18, 2022

Conversation

int-y1
Copy link
Contributor

@int-y1 int-y1 commented May 27, 2022

Make sure that SITE_ADMIN_EMAIL gets into the template. The new email looks like this:

<span style="display:block;margin: 0 2px;padding: 1em;border: 3px solid #FFDE05;background-color: #000;border-radius: 6px;font-size: .95em;color: #444;margin-bottom:0.75em">
<div style="display:table;margin-left:2em"><img src="https://avatars1.githubusercontent.com/u/6934864?v=3&s=101" style="display:inline;vertical-align: middle">
<h1 style="font-size:4em;display:inline;vertical-align: middle"><a href="http://localhost:8081" style="text-decoration:none;color:gray"><span style="color: #FFDE05">DM::</span>OJ</a>
      </h1>
</div>
</span>
<div style="display:block;margin: 0 2px;padding: 1em;border: 3px solid #2980B9;background-color: #f8f8f8;border-radius: 6px;font-size: .95em;color: #444;">

<b>Forgot your password on the DMOJ: Modern Online Judge? Don&#39;t worry!</b><br><br>
To reset the password for your account &quot;admin&quot;, click the button below.
<p align="center">
<a href="http://localhost:8081/accounts/password/reset/confirm/Mg-61r-c918e2d258427a7110d8/" style="cursor: pointer;display:block;text-align: center;padding: 4px 2px 5px;color: white;border: 1px solid #666;border-radius: 1px;background: #2980b9;background: linear-gradient(180deg, #00aee0, #2980b9);text-decoration: none;line-height:2em;font-size:1em;width:12em;">Reset Password</a>
</p>
See you soon! If you have problems resetting your password, feel free to shoot us an email at <a href="mailto:admin@example.com">admin@example.com</a>.
</div>

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2022

Codecov Report

Merging #1945 (86ee074) into master (966b37d) will increase coverage by 0.01%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master    #1945      +/-   ##
==========================================
+ Coverage   46.46%   46.47%   +0.01%     
==========================================
  Files         236      236              
  Lines       13114    13118       +4     
==========================================
+ Hits         6093     6097       +4     
  Misses       7021     7021              
Impacted Files Coverage Δ
dmoj/urls.py 89.47% <ø> (ø)
judge/views/user.py 39.20% <80.00%> (+0.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 966b37d...86ee074. Read the comment docs.

@int-y1 int-y1 force-pushed the fix-pw-reset-again branch from a78f332 to 2d0e992 Compare June 19, 2022 02:17
@int-y1 int-y1 force-pushed the fix-pw-reset-again branch from 2d0e992 to 86ee074 Compare June 22, 2022 04:31
Copy link
Member

@Xyene Xyene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Xyene Xyene merged commit e24f413 into DMOJ:master Jul 18, 2022
@int-y1 int-y1 deleted the fix-pw-reset-again branch July 25, 2022 06:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants