Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Refactor user submission table's js #1954

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Conversation

int-y1
Copy link
Contributor

@int-y1 int-y1 commented Jun 4, 2022

JS's ngettext doesn't work in templates/, so move it to resources/.

i18n: python manage.py makemessages -l en -d djangojs detected all 5 i18n strings and put them in djangojs.po.

JS compatibility: The submission table works in IE11. (This required a lot of small changes)

Capture

@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2022

Codecov Report

Merging #1954 (c745bd8) into master (966b37d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1954   +/-   ##
=======================================
  Coverage   46.46%   46.46%           
=======================================
  Files         236      236           
  Lines       13114    13114           
=======================================
  Hits         6093     6093           
  Misses       7021     7021           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 966b37d...c745bd8. Read the comment docs.

@kiritofeng
Copy link
Member

I feel like "not working in IE" is totally fine (iirc MS is going to deprecate IE mode soon:tm:)

@int-y1
Copy link
Contributor Author

int-y1 commented Jun 6, 2022

I feel like "not working in IE" is totally fine (iirc MS is going to deprecate IE mode soon™️)

I did it to prevent fc25c65 from happening again.

Copy link
Member

@Xyene Xyene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Xyene Xyene merged commit 859877c into DMOJ:master Oct 31, 2022
@int-y1 int-y1 deleted the user-sub-table branch October 31, 2022 03:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants