Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add i18n to server-side messages #1980

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Add i18n to server-side messages #1980

merged 1 commit into from
Oct 28, 2022

Conversation

int-y1
Copy link
Contributor

@int-y1 int-y1 commented Jul 27, 2022

Affected pages:

  • /admin/judge/contest/1/change/ > Problems > Rejudge column
  • /admin/judge/judge/add/ > Regenerate button
  • /admin/judge/submission/ > Rejudge button (and Locked button, if sub is locked)
  • /contest/c1/participations/<user> page's title
  • Too many running submissions
  • Submit to an unviewable problem

@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2022

Codecov Report

Merging #1980 (69c6dd5) into master (8faf2bf) will increase coverage by 0.00%.
The diff coverage is 12.50%.

@@           Coverage Diff           @@
##           master    #1980   +/-   ##
=======================================
  Coverage   46.51%   46.51%           
=======================================
  Files         236      236           
  Lines       13085    13086    +1     
=======================================
+ Hits         6086     6087    +1     
  Misses       6999     6999           
Impacted Files Coverage Δ
judge/admin/contest.py 43.45% <0.00%> (ø)
judge/admin/runtime.py 66.66% <ø> (ø)
judge/views/contests.py 29.23% <0.00%> (ø)
judge/views/problem.py 24.19% <0.00%> (ø)
judge/admin/submission.py 44.89% <33.33%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8faf2bf...69c6dd5. Read the comment docs.

Copy link
Member

@Xyene Xyene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Xyene Xyene merged commit 9624b0b into DMOJ:master Oct 28, 2022
@int-y1 int-y1 deleted the add-i18n branch October 28, 2022 05:49
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants