Fix pwned passwords throwing ValueError
#1991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relevant upstream issue: ubernostrum/pwned-passwords-django#35
Codecov Report
@@ Coverage Diff @@
## master #1991 +/- ##
=======================================
Coverage 46.51% 46.51%
=======================================
Files 236 236
Lines 13085 13085
=======================================
Hits 6086 6086
Misses 6999 6999
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
int-y1
suggested changes
Aug 27, 2022
|
This code is copied from https://github.com/ubernostrum/pwned-passwords-django. I think we should match upstream, but other opinions are welcome. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant upstream issue: ubernostrum/pwned-passwords-django#35