Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Clean up comment CSS #2070

Merged
merged 1 commit into from
Dec 17, 2022
Merged

Clean up comment CSS #2070

merged 1 commit into from
Dec 17, 2022

Conversation

Ninjaclasher
Copy link
Member

Part of #2035.

  • Move comment CSS from HTML to SCSS
  • Colour changes:
    • #fafafa -> #f8f8f8 (color_primary5)
    • #888 -> #808080 (color_primary50)
    • #444 -> #3b3b3b (color_primary75)
  • Colour renames:
    • #ccc -> color_primary25
    • #2980b9 -> highlight_blue

Light theme:
image
Dark theme:
image

@codecov-commenter
Copy link

Codecov Report

Base: 46.44% // Head: 46.44% // No change to project coverage 👍

Coverage data is based on head (38b8a94) compared to base (3245fb3).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2070   +/-   ##
=======================================
  Coverage   46.44%   46.44%           
=======================================
  Files         236      236           
  Lines       13072    13072           
=======================================
  Hits         6071     6071           
  Misses       7001     7001           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@Xyene Xyene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Xyene Xyene merged commit 30e0b51 into DMOJ:master Dec 17, 2022
@Ninjaclasher Ninjaclasher deleted the comment-dark-css branch December 17, 2022 23:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants